Skip to content

Commit

Permalink
LPS-112018 Remove <clay:button> and use hardcoded markup
Browse files Browse the repository at this point in the history
  • Loading branch information
ambrinchaudhary authored and 4lejandrito committed Apr 16, 2020
1 parent dd25b89 commit bb9f212
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 27 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,7 @@

<%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c" %>

<%@ taglib uri="http://liferay.com/tld/clay" prefix="clay" %><%@
taglib uri="http://liferay.com/tld/frontend" prefix="liferay-frontend" %><%@
<%@ taglib uri="http://liferay.com/tld/frontend" prefix="liferay-frontend" %><%@
taglib uri="http://liferay.com/tld/react" prefix="react" %><%@
taglib uri="http://liferay.com/tld/theme" prefix="liferay-theme" %><%@
taglib uri="http://liferay.com/tld/ui" prefix="liferay-ui" %><%@
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@ String type = GetterUtil.getString((String)request.getAttribute("liferay-ratings
<c:choose>
<c:when test="<%= type.equals(RatingsType.LIKE.getValue()) %>">
<div>
<clay:button
disabled="<%= true %>"
elementClasses="btn-outline-borderless btn-outline-secondary btn-sm"
icon="heart"
/>
<button class="btn btn-outline-borderless btn-outline-secondary btn-sm" disabled type="button">
<svg class="lexicon-icon lexicon-icon-heart">
<use xlink:href="<%= themeDisplay.getPathThemeImages() %>/lexicon/icons.svg#heart" />
</svg>
</button>

<react:component
data="<%= data %>"
Expand All @@ -49,17 +49,17 @@ String type = GetterUtil.getString((String)request.getAttribute("liferay-ratings
</c:when>
<c:when test="<%= type.equals(RatingsType.THUMBS.getValue()) %>">
<div>
<clay:button
disabled="<%= true %>"
elementClasses="btn-outline-borderless btn-outline-secondary btn-sm"
icon="thumbs-up"
/>
<button class="btn btn-outline-borderless btn-outline-secondary btn-sm" disabled type="button">
<svg class="lexicon-icon lexicon-icon-thumbs-up">
<use xlink:href="<%= themeDisplay.getPathThemeImages() %>/lexicon/icons.svg#thumbs-up" />
</svg>
</button>

<clay:button
disabled="<%= true %>"
elementClasses="btn-outline-borderless btn-outline-secondary btn-sm"
icon="thumbs-down"
/>
<button class="btn btn-outline-borderless btn-outline-secondary btn-sm" disabled type="button">
<svg class="lexicon-icon lexicon-icon-thumbs-down">
<use xlink:href="<%= themeDisplay.getPathThemeImages() %>/lexicon/icons.svg#thumbs-down" />
</svg>
</button>

<react:component
data="<%= data %>"
Expand All @@ -72,20 +72,20 @@ String type = GetterUtil.getString((String)request.getAttribute("liferay-ratings
<div class="autofit-row autofit-row-center ratings ratings-stars">
<div class="autofit-col">
<div class="dropdown">
<clay:button
disabled="<%= true %>"
elementClasses="btn btn-outline-borderless btn-outline-secondary btn-sm dropdown-toggle"
icon="star-o"
label="-"
/>
<button class="btn btn-outline-borderless btn-outline-secondary dropdown-toggle btn-sm" disabled type="button">
<svg class="lexicon-icon lexicon-icon-star-o">
<use xlink:href="<%= themeDisplay.getPathThemeImages() %>/lexicon/icons.svg#star-o" />
</svg>

<span>-</span>
</button>
</div>
</div>

<div class="autofit-col">
<clay:icon
elementClasses="ratings-stars-average-icon"
symbol="star"
/>
<svg class="lexicon-icon lexicon-icon-star ratings-stars-average-icon">
<use xlink:href="<%= themeDisplay.getPathThemeImages() %>/lexicon/icons.svg#star" />
</svg>
</div>
</div>

Expand Down

0 comments on commit bb9f212

Please sign in to comment.