Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor const std::shared_ptr<T> to std::shared_ptr<const T> #1293

Closed
zhanghaohit opened this issue Feb 23, 2022 · 2 comments
Closed

refactor const std::shared_ptr<T> to std::shared_ptr<const T> #1293

zhanghaohit opened this issue Feb 23, 2022 · 2 comments
Assignees
@IZUMI-Zu
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zhanghaohit
Copy link
Collaborator

It should be the std::shared_ptr<const T>, which means the data pointed by the shared_ptr cannot be changed rather than the shared_ptr itself cannot be changed.

e.g., const std::shared_ptr<OptionsMap> options_
@zhanghaohit zhanghaohit added the bug Something isn't working label Feb 23, 2022
@zhanghaohit zhanghaohit self-assigned this Feb 23, 2022
@aceforeverd aceforeverd added the good first issue Good for newcomers label Feb 25, 2022
@lumianph lumianph mentioned this issue May 10, 2022
Closed
@Cupid0320 Cupid0320 mentioned this issue May 11, 2022
Open
@IZUMI-Zu
Copy link
Contributor

Can I have a try?

@lumianph
Copy link
Collaborator

Can I have a try?

sure! I have assigned to you. Thanks.

@IZUMI-Zu IZUMI-Zu mentioned this issue May 13, 2022
Closed
@dl239 dl239 closed this as completed Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IZUMI-Zu IZUMI-Zu

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: change const std::shared_ptr<T> to std::shared_ptr<const T> IZUMI-Zu/OpenMLDB
5 participants
@lumianph @dl239 @zhanghaohit @aceforeverd @IZUMI-Zu