Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set the constant in getSQLStateType #1758

Closed
vagetablechicken opened this issue May 7, 2022 · 1 comment · Fixed by #1781
Closed

set the constant in getSQLStateType #1758

vagetablechicken opened this issue May 7, 2022 · 1 comment · Fixed by #1781
Labels
good first issue Good for newcomers

Comments

@vagetablechicken
Copy link
Collaborator

OpenMLDB/java/openmldb-jdbc/src/main/java/com/_4paradigm/openmldb/jdbc/DatabaseMetaData.java

Lines 1014 to 1016 in 9389d90

public int getSQLStateType() throws SQLException {
return 0;
}

return 0; is not good. Change it to sqlStateSQL99.
@vagetablechicken vagetablechicken added the good first issue Good for newcomers label May 7, 2022
@lumianph lumianph mentioned this issue May 10, 2022
Closed
@SaumyaBhushan
Copy link
Contributor

I would like to help

@SaumyaBhushan SaumyaBhushan mentioned this issue May 10, 2022
Merged
@dl239 dl239 linked a pull request May 10, 2022 that will close this issue
refactor: set the constant in getSQLStateType #1781
Merged
@Cupid0320 Cupid0320 mentioned this issue May 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: set the constant in getSQLStateType SaumyaBhushan/OpenMLDB
2 participants
@vagetablechicken @SaumyaBhushan