Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable python style check via pylint #315

Closed
aceforeverd opened this issue Aug 30, 2021 · 6 comments · Fixed by #1873
Closed

enable python style check via pylint #315

aceforeverd opened this issue Aug 30, 2021 · 6 comments · Fixed by #1873
Assignees
@mangoGoForward
Labels
code-standards code style/convention things good first issue Good for newcomers
Milestone
v0.6

Comments

@aceforeverd
Copy link
Collaborator

aceforeverd commented Aug 30, 2021 •
edited by lumianph
Loading

Expected Behavior

using Pylint for python code style check for pull requests

Current Behavior

there is pylintrc already, but no pylint workflow

Possible Solution

adding pylint check to .github/workflows/style.yml

Notice

  • there seems no reviewdog-pylint available, it's fine to run pylint directly
  • the current code may generate many errors after enabling Pylint, you may skip specifying the directory for Pylint check in this issue (PRs to fix those error are also welcome)
@aceforeverd aceforeverd added python code-standards code style/convention things labels Aug 30, 2021
@imotai imotai added the good first issue Good for newcomers label Aug 31, 2021
@Nagateja22

This comment has been minimized.

Sign in to view
@aceforeverd

This comment has been minimized.

Sign in to view
@dl239 dl239 removed the python label Sep 24, 2021
@lumianph lumianph mentioned this issue Dec 2, 2021
Closed
@lumianph lumianph mentioned this issue Feb 28, 2022
Closed
@lumianph lumianph mentioned this issue May 10, 2022
Closed
@Cupid0320 Cupid0320 mentioned this issue May 11, 2022
Open
@mangoGoForward
Copy link
Contributor

[WeOpen Star]I would like to help

@mangoGoForward
Copy link
Contributor

Hi @aceforeverd
Should we separate two PRs to support pylint check and fix pylint errors?

@aceforeverd
Copy link
Collaborator Author

aceforeverd commented May 24, 2022 •
edited
Loading

Hi @aceforeverd Should we separate two PRs to support pylint check and fix pylint errors?

I recommend separate it. There suppose to be many errors from pylint.

@mangoGoForward
Copy link
Contributor

I recommend separate it. There suppose to be many errors from pylint.

Yes, I noticed. Please let me try~

@mangoGoForward mangoGoForward mentioned this issue May 24, 2022
Merged
@aceforeverd aceforeverd added this to the v0.6 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mangoGoForward mangoGoForward

Labels
code-standards code style/convention things good first issue Good for newcomers
Projects
None yet
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

feat: support pylint check in github action
5 participants
@dl239 @imotai @aceforeverd @mangoGoForward @Nagateja22