Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert statement: codegen insert rows #3731

Open
3 tasks
aceforeverd opened this issue Jan 29, 2024 · 0 comments
Open
3 tasks

insert statement: codegen insert rows #3731

aceforeverd opened this issue Jan 29, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet

Comments

@aceforeverd
Copy link
Collaborator

aceforeverd commented Jan 29, 2024

we only support insert stmt with base type expressions, so

# 1.
insert into t1 values (1, 2);

# 2
insert to t1 values (1, map(1,"12"), inc(3), [3, 4, 5]);

1 works with legacy solution, but not 2. Codegen rows support both.

Big work since the complexity for insert statements, as well as the SDK in java and python.

  • native codegen insert rows: consider table default value and parameters
  • Java & Python SDK
  • offline batch

#3723 initiate codegen rows for values that contains map data type only, more work required

@aceforeverd aceforeverd added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet enhancement New feature or request labels Jan 29, 2024
aceforeverd added a commit to aceforeverd/fedb that referenced this issue Jan 29, 2024
simple insert row codegen support from 4paradigm#3731.
@aceforeverd aceforeverd self-assigned this Jan 29, 2024
aceforeverd added a commit to aceforeverd/fedb that referenced this issue Feb 4, 2024
simple insert row codegen support from 4paradigm#3731.
aceforeverd added a commit to aceforeverd/fedb that referenced this issue Feb 7, 2024
simple insert row codegen support from 4paradigm#3731.
aceforeverd added a commit to aceforeverd/fedb that referenced this issue Feb 29, 2024
simple insert row codegen support from 4paradigm#3731.
aceforeverd added a commit to aceforeverd/fedb that referenced this issue Mar 4, 2024
simple insert row codegen support from 4paradigm#3731.
aceforeverd added a commit that referenced this issue Mar 5, 2024
* feat: create table with map type columns

* feat: insert stmt support for map data type

simple insert row codegen support from #3731.

* test: fix plan tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

No branches or pull requests

1 participant