Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: release compile image via tag push v* and some updates to docs #3074

Merged
merged 3 commits into from
Feb 17, 2023
Merged

feat: release compile image via tag push v* and some updates to docs #3074

merged 3 commits into from
Feb 17, 2023

Conversation

aceforeverd
Copy link
Collaborator

  • release compile image via tag v* push
  • tweak to with clause

@aceforeverd
ci!(compile image): trigger via 'v*' tag push instead 'docker-*' tag
61dad00 
Other compile job takes the image 'hybridsql::latest' as compile image,
latest always refer to the latest thirdparty version requires. So it
should possibly not necessary to separate release of OpenMLDB and
compile image.

For general guideline of thirdparty changes, developer must separate the
change to thirdparty build and actually code change into different pull
request, or the CI job will not pass.
@aceforeverd
docs: tweak to with clause
45e0d54
@github-actions github-actions bot added documentation Improvements or additions to documentation workflow CICD related labels Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023 •
edited
Loading

Codecov Report

Base: 75.69% // Head: 75.66% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (7993ef3) compared to base (61ee03d).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #3074      +/-   ##
============================================
- Coverage     75.69%   75.66%   -0.03%     
  Complexity      393      393              
============================================
  Files           664      664              
  Lines        124607   124607              
  Branches       1113     1113              
============================================
- Hits          94319    94285      -34     
- Misses        30052    30086      +34     
  Partials        236      236
Impacted Files Coverage Δ
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
src/rpc/rpc_client.h 70.78% <0.00%> (-3.38%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/catalog/tablet_catalog.cc 71.54% <0.00%> (-0.80%) ⬇️
src/replica/replicate_node.cc 78.21% <0.00%> (-0.56%) ⬇️
src/storage/mem_table.cc 89.13% <0.00%> (-0.44%) ⬇️
src/tablet/tablet_impl.cc 63.48% <0.00%> (-0.34%) ⬇️
src/client/tablet_client.cc 58.77% <0.00%> (-0.12%) ⬇️
src/nameserver/name_server_impl.cc 44.53% <0.00%> (-0.09%) ⬇️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the docker openmldb compile image or demo image label Feb 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2023 •
edited
Loading

SDK Test Report

  89 files    89 suites   1m 23s ⏱️
180 tests 171 ✔️ 9 💤 0 ❌
226 runs  217 ✔️ 9 💤 0 ❌

Results for commit 7993ef3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Linux Test Report

       56 files       230 suites   1h 12m 18s ⏱️
11 890 tests 11 883 ✔️ 7 💤 0 ❌
16 876 runs  16 869 ✔️ 7 💤 0 ❌

Results for commit 7993ef3.

vagetablechicken
vagetablechicken requested changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@vagetablechicken vagetablechicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is right? 'tweak to compile' ?

@aceforeverd aceforeverd changed the title feat: tweak to compile image release and doc feat: update to compile image release and doc Feb 17, 2023
@aceforeverd
Copy link
Collaborator Author

The title is right? 'tweak to compile' ?

help me change the title ? It's about compile image release in ci

@vagetablechicken
Copy link
Collaborator

vagetablechicken commented Feb 17, 2023 •
edited
Loading

The title is right? 'tweak to compile' ?

help me change the title ? It's about compile image release in ci

I think trigger docker relse via 'v*' tag and doc fix is ok, just let us know the changes. I'm confused about what compile tweaks when I read the title.

@aceforeverd aceforeverd changed the title feat: update to compile image release and doc feat: release compile image via tag push v* and some updates to docs Feb 17, 2023
@aceforeverd
Copy link
Collaborator Author

The title is right? 'tweak to compile' ?

help me change the title ? It's about compile image release in ci

I think trigger docker relse via 'v*' tag and doc fix is ok, just let us know the changes. I'm confused about what compile tweaks when I read the title.

corrected, thx

@aceforeverd aceforeverd merged commit 9aa97b1 into 4paradigm:main Feb 17, 2023
@aceforeverd aceforeverd deleted the feat-compile-image branch February 17, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dl239 dl239 dl239 approved these changes

@vagetablechicken vagetablechicken vagetablechicken approved these changes

@tobegit3hub tobegit3hub Awaiting requested review from tobegit3hub

@zhanghaohit zhanghaohit Awaiting requested review from zhanghaohit

Assignees
No one assigned
Labels
docker openmldb compile image or demo image documentation Improvements or additions to documentation workflow CICD related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aceforeverd @vagetablechicken @dl239