Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(udf): top_n_value_ratio_cate & top_n_value_key_ratio_cate #3329

Merged
merged 10 commits into from
Jun 28, 2023
Merged

feat(udf): top_n_value_ratio_cate & top_n_value_key_ratio_cate #3329

merged 10 commits into from
Jun 28, 2023

Conversation

aceforeverd
Copy link
Collaborator

@aceforeverd aceforeverd commented Jun 20, 2023 •
edited
Loading

  • top_n_value_ratio_cate
  • top_n_key_ratio_cate
  • list_except_by_key
  • list_except_by_value

@github-actions github-actions bot added the execute-engine hybridse sql engine label Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023 •
edited
Loading

Codecov Report

Patch coverage: 96.03% and project coverage change: +38.42 🎉

Comparison is base (82d1929) 37.27% compared to head (23d56bd) 75.70%.

Additional details and impacted files 
@@              Coverage Diff              @@
##               main    #3329       +/-   ##
=============================================
+ Coverage     37.27%   75.70%   +38.42%     
  Complexity      414      414               
=============================================
  Files           177      692      +515     
  Lines         10238   125912   +115674     
  Branches       1189     1189               
=============================================
+ Hits           3816    95316    +91500     
- Misses         6181    30355    +24174     
  Partials        241      241
Impacted Files Coverage Δ
...idse/src/udf/default_defs/count_by_category_def.cc 100.00% <ø> (ø)
...bridse/src/udf/default_defs/max_by_category_def.cc 100.00% <ø> (ø)
...bridse/src/udf/default_defs/min_by_category_def.cc 100.00% <ø> (ø)
...bridse/src/udf/default_defs/sum_by_category_def.cc 100.00% <ø> (ø)
...ridse/src/udf/default_defs/window_functions_def.cc 84.90% <ø> (ø)
hybridse/src/udf/containers.h 89.63% <85.00%> (ø)
hybridse/src/udf/default_defs/feature_zero_def.cc 84.35% <94.59%> (ø)
hybridse/src/udf/default_defs/aggregate_def.cc 100.00% <100.00%> (ø)
...bridse/src/udf/default_defs/avg_by_category_def.cc 100.00% <100.00%> (ø)
hybridse/src/udf/default_defs/containers.h 100.00% <100.00%> (ø)

... and 505 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aceforeverd aceforeverd marked this pull request as ready for review June 21, 2023 12:57
@aceforeverd aceforeverd changed the title feat(udf): top_n_value_ratio_cate_where & top_n_value_key_ratio_cate_where feat(udf): top_n_value_ratio_cate & top_n_value_key_ratio_cate Jun 26, 2023
@aceforeverd aceforeverd merged commit e060307 into 4paradigm:main Jun 28, 2023
27 checks passed
@aceforeverd aceforeverd deleted the feat-cate-ratio branch June 28, 2023 06:34
dl239 pushed a commit that referenced this pull request Jun 29, 2023
@aceforeverd @dl239
feat(udf): top_n_value_ratio_cate & top_n_value_key_ratio_cate (#3329)
ea0cbde 
- top_n_value_ratio_cate
- top_n_key_ratio_cate
- list_except_by_key
- list_except_by_value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dl239 dl239 dl239 approved these changes

@vagetablechicken vagetablechicken vagetablechicken approved these changes

@lqy222 lqy222 Awaiting requested review from lqy222

Assignees
No one assigned
Labels
execute-engine hybridse sql engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aceforeverd @dl239 @vagetablechicken