Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support showing jobs sorted by id #3371

Merged
merged 12 commits into from
Aug 7, 2023

Conversation

emo-coder
Copy link
Contributor

@emo-coder emo-coder commented Jul 17, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    close show sorted jobs #3173

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jul 17, 2023
@emo-coder emo-coder changed the title support showing jobs sorted by id feat: support showing jobs sorted by id Jul 17, 2023
src/sdk/job_table_helper.cc Outdated Show resolved Hide resolved
src/sdk/sql_cluster_test.cc Outdated Show resolved Hide resolved
src/sdk/job_table_helper.cc Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c4a8371) 75.70% compared to head (0516de0) 75.70%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3371   +/-   ##
=========================================
  Coverage     75.70%   75.70%           
  Complexity      414      414           
=========================================
  Files           700      701    +1     
  Lines        126668   126690   +22     
  Branches       1206     1206           
=========================================
+ Hits          95888    95910   +22     
  Misses        30539    30539           
  Partials        241      241           
Files Changed Coverage Δ
src/sdk/job_table_helper.cc 35.84% <0.00%> (-3.33%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/sdk/job_table_helper.cc Outdated Show resolved Hide resolved
src/sdk/sql_cluster_test.cc Outdated Show resolved Hide resolved
@dl239 dl239 marked this pull request as ready for review July 18, 2023 10:36
src/sdk/sql_cluster_test.cc Outdated Show resolved Hide resolved
@@ -17,6 +17,7 @@
#include "sdk/job_table_helper.h"

#include <unordered_map>
#include <algorithm>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reorder the header file

@dl239 dl239 merged commit 3a17aec into 4paradigm:main Aug 7, 2023
21 of 22 checks passed
dl239 pushed a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show sorted jobs
5 participants