Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: twine and urllib mismatch #3386

Merged
merged 2 commits into from
Jul 26, 2023
Merged

fix: twine and urllib mismatch #3386

merged 2 commits into from
Jul 26, 2023

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jul 20, 2023

https://github.com/4paradigm/OpenMLDB/actions/runs/5610579829/jobs/10265741147

twine and urllib mismatch issue has been resolved in #3343. but openmldb-tool will install 1.25 urllib after twine installed.

@github-actions github-actions bot added the workflow CICD related label Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +38.45 🎉

Comparison is base (d5647d1) 37.25% compared to head (0fc567f) 75.71%.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3386       +/-   ##
=============================================
+ Coverage     37.25%   75.71%   +38.45%     
  Complexity      414      414               
=============================================
  Files           177      700      +523     
  Lines         10294   126659   +116365     
  Branches       1206     1206               
=============================================
+ Hits           3835    95897    +92062     
- Misses         6218    30521    +24303     
  Partials        241      241               

see 523 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dl239 dl239 enabled auto-merge (squash) July 25, 2023 11:19
@dl239 dl239 merged commit c4a8371 into 4paradigm:main Jul 26, 2023
21 checks passed
@dl239 dl239 deleted the fix/twine_urllib branch July 26, 2023 06:05
dl239 added a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow CICD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants