Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop success if pid does not exist #3427

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Aug 7, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Aug 7, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -38.19% ⚠️

Comparison is base (1b8d596) 75.33% compared to head (99c82de) 37.14%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3427       +/-   ##
=============================================
- Coverage     75.33%   37.14%   -38.19%     
  Complexity      414      414               
=============================================
  Files           707      179      -528     
  Lines        128428    10364   -118064     
  Branches       1191     1191               
=============================================
- Hits          96751     3850    -92901     
+ Misses        31436     6273    -25163     
  Partials        241      241               

see 528 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dl239 dl239 marked this pull request as ready for review August 21, 2023 03:18
@dl239 dl239 merged commit 1ea8e58 into 4paradigm:main Aug 29, 2023
23 of 25 checks passed
@dl239 dl239 deleted the feat/drop_table branch August 29, 2023 01:23
dl239 added a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants