Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop non empty offline path #3654

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

vagetablechicken
Copy link
Collaborator

closes #3340

@github-actions github-actions bot added the task-manager openmldb taskmanager label Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d1d2e38) 74.95% compared to head (c1ba352) 74.95%.

Files Patch % Lines
...paradigm/openmldb/taskmanager/JobInfoManager.scala 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3654   +/-   ##
=========================================
  Coverage     74.95%   74.95%           
  Complexity      640      640           
=========================================
  Files           724      724           
  Lines        130414   130414           
  Branches       1325     1325           
=========================================
+ Hits          97752    97758    +6     
+ Misses        32369    32363    -6     
  Partials        293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vagetablechicken vagetablechicken merged commit 0c2592d into 4paradigm:main Dec 8, 2023
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task-manager openmldb taskmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dropOfflineTable shouldn't use field deepCopy
3 participants