Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local load/write validate and refactor #3666

Merged
merged 12 commits into from
Dec 21, 2023

Conversation

vagetablechicken
Copy link
Collaborator

closes #3639

@github-actions github-actions bot added documentation Improvements or additions to documentation build openmldb compiling and installing execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (a8c0226) 40.16% compared to head (788cb58) 74.94%.
Report is 7 commits behind head on main.

Files Patch % Lines
src/sdk/sql_cluster_router.cc 75.00% 20 Missing ⚠️
src/sdk/options_map_parser.h 94.19% 9 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3666       +/-   ##
=============================================
+ Coverage     40.16%   74.94%   +34.77%     
- Complexity      640      642        +2     
=============================================
  Files           191      725      +534     
  Lines         11233   130896   +119663     
  Branches       1325     1323        -2     
=============================================
+ Hits           4512    98099    +93587     
- Misses         6428    32504    +26076     
  Partials        293      293               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vagetablechicken vagetablechicken merged commit ebe1f7d into 4paradigm:main Dec 21, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build openmldb compiling and installing documentation Improvements or additions to documentation storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read option parsing is not good
3 participants