Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: coverage #3774

Merged
merged 14 commits into from
Feb 26, 2024
Merged

fix: coverage #3774

merged 14 commits into from
Feb 26, 2024

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Feb 22, 2024

When glog compiles a static library, it will hide some symbols in v0.6.0 (refer here) so that coverage cannot find the symbols in linking stage when it relies on the dynamic libraries

2024-02-23T06:19:25.8332883Z /usr/bin/ld: cmd/single_tablet_test: hidden symbol `_ZN6google10LogMessageC1EPKcii' in /home/runner/work/OpenMLDB/OpenMLDB/.deps/usr/lib/libglog.a(logging.cc.o) is referenced by DSO
2024-02-23T06:19:25.8335221Z /usr/bin/ld: final link failed: bad value
2024-02-23T06:19:25.8336221Z collect2: error: ld returned 1 exit status

A quick temporary solution is to compile the glog dynamic library before running coverage

@github-actions github-actions bot added build openmldb compiling and installing docker openmldb compile image or demo image labels Feb 22, 2024
Copy link
Contributor

github-actions bot commented Feb 22, 2024

Linux Test Report

    57 files  +    57     244 suites  +244   1h 16m 45s ⏱️ + 1h 16m 45s
12 583 tests +12 583  12 576 ✅ +12 576  7 💤 +7  0 ❌ ±0 
17 840 runs  +17 840  17 833 ✅ +17 833  7 💤 +7  0 ❌ ±0 

Results for commit 42b74c5. ± Comparison against base commit 47a61cb.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 22, 2024

SDK Test Report

101 files  ±0  101 suites  ±0   2m 6s ⏱️ +4s
345 tests ±0  331 ✅ ±0  14 💤 ±0  0 ❌ ±0 
471 runs  ±0  457 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit 42b74c5. ± Comparison against base commit 47a61cb.

This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added workflow CICD related and removed docker openmldb compile image or demo image labels Feb 22, 2024
@github-actions github-actions bot removed the build openmldb compiling and installing label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.88%. Comparing base (47a61cb) to head (42b74c5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3774       +/-   ##
=============================================
+ Coverage     40.26%   74.88%   +34.61%     
  Complexity      658      658               
=============================================
  Files           194      737      +543     
  Lines         11426   132521   +121095     
  Branches       1378     1378               
=============================================
+ Hits           4601    99240    +94639     
- Misses         6521    32977    +26456     
  Partials        304      304               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aceforeverd
Copy link
Collaborator

That should the common issue when linking a shared library against static libraray, see https://stackoverflow.com/questions/23696585/what-does-exactly-the-warning-mean-about-hidden-symbol-being-referenced-by-dso

So I've try bundle source code of glog (plug gflags and anything necessary), then we can link at least gflag & glog from source

@dl239 dl239 marked this pull request as ready for review February 23, 2024 12:58
@aceforeverd
Copy link
Collaborator

it build glog_shared, and FindPackage(glog) will find shared library first ?

@dl239
Copy link
Collaborator Author

dl239 commented Feb 26, 2024

it build glog_shared, and FindPackage(glog) will find shared library first ?

It seems so

@dl239 dl239 enabled auto-merge (squash) February 26, 2024 02:53
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit a8d7a1d into 4paradigm:main Feb 26, 2024
23 checks passed
@dl239 dl239 deleted the fix/coverage branch February 26, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow CICD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants