Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete with same ts #3780

Merged
merged 3 commits into from Feb 27, 2024
Merged

fix: delete with same ts #3780

merged 3 commits into from Feb 27, 2024

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Feb 26, 2024 •
edited

  • fix integration-test
  • fix hybridse-ci compiling error on macos

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Feb 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited

SDK Test Report

101 files  ±0  101 suites  ±0   2m 5s ⏱️ -3s
345 tests ±0  331 ✅ ±0  14 💤 ±0  0 ❌ ±0 
471 runs  ±0  457 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit 6c72655. ± Comparison against base commit 76af71c.

♻️ This comment has been updated with latest results.

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.91%. Comparing base (76af71c) to head (6c72655).

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #3780      +/-   ##
============================================
+ Coverage     74.90%   74.91%   +0.01%     
  Complexity      658      658              
============================================
  Files           737      737              
  Lines        132533   132541       +8     
  Branches       1380     1380              
============================================
+ Hits          99269    99290      +21     
+ Misses        32960    32947      -13     
  Partials        304      304

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited

Linux Test Report

    57 files  ±0     244 suites  ±0   1h 18m 15s ⏱️ +8s
12 585 tests +2  12 578 ✅ +2  7 💤 ±0  0 ❌ ±0 
17 842 runs  +2  17 835 ✅ +2  7 💤 ±0  0 ❌ ±0 

Results for commit 6c72655. ± Comparison against base commit 76af71c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited

HybridSE Linux Test Report

20 094 tests   20 092 ✅  6m 8s ⏱️
   255 suites       2 💤
    67 files         0 ❌

Results for commit 6c72655.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2024 •
edited

HybridSE Mac Test Report

20 094 tests   20 092 ✅  7m 54s ⏱️
   255 suites       2 💤
    67 files         0 ❌

Results for commit 6c72655.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

SRC java-sdk-cluster-memory-0 Report

4 660 tests   4 660 ✔️  38m 45s ⏱️
       1 suites         0 💤
       1 files           0 ❌

Results for commit c104830.

@github-actions GitHub Actions
Copy link
Contributor

SRC java-sdk-cluster-hdd Report

4 215 tests   4 215 ✔️  16m 44s ⏱️
       1 suites         0 💤
       1 files           0 ❌

Results for commit c104830.

@github-actions GitHub Actions
Copy link
Contributor

SRC apiserver-cluster Report

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit c104830.

@github-actions GitHub Actions
Copy link
Contributor

SRC java-sdk-cluster-memory-1 Report

5 812 tests   5 812 ✔️  6m 2s ⏱️
       1 suites         0 💤
       1 files           0 ❌

Results for commit c104830.

@github-actions GitHub Actions
Copy link
Contributor

SRC java-sdk-cluster-ssd Report

4 215 tests   4 215 ✔️  13m 24s ⏱️
       1 suites         0 💤
       1 files           0 ❌

Results for commit c104830.

@github-actions GitHub Actions
Copy link
Contributor

SRC java-yarn Report

1 tests   0 ✔️  4s ⏱️
1 suites  0 💤
1 files    1 ❌

For more details on these failures, see this check.

Results for commit c104830.

@github-actions github-actions bot added the workflow CICD related label Feb 27, 2024
dl239
dl239 commented Feb 27, 2024
View reviewed changes
.github/workflows/hybridse-ci.yml
@@ -61,7 +61,7 @@ jobs:

- name: Install dependencies
run: |
brew install coreutils
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert here after removing llvm z3 dependency in #3777 @aceforeverd

@dl239 dl239 merged commit ad4eace into 4paradigm:main Feb 27, 2024
32 checks passed
@dl239 dl239 deleted the fix/delete_same_ts branch February 27, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aceforeverd aceforeverd aceforeverd approved these changes

@vagetablechicken vagetablechicken vagetablechicken approved these changes

@tobegit3hub tobegit3hub Awaiting requested review from tobegit3hub

Assignees
No one assigned
Labels
storage-engine openmldb storage engine. nameserver & tablet workflow CICD related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dl239 @aceforeverd @vagetablechicken