Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: offline with git submodule #3787

Merged
merged 16 commits into from Mar 4, 2024

Conversation

QiChenX
Copy link
Collaborator

@QiChenX QiChenX commented Feb 28, 2024

@github-actions github-actions bot added build openmldb compiling and installing docker openmldb compile image or demo image labels Feb 28, 2024
@aceforeverd
Copy link
Collaborator

requires #3778

Copy link
Contributor

github-actions bot commented Feb 28, 2024

SDK Test Report

101 files  ±0  101 suites  ±0   2m 4s ⏱️ -4s
345 tests ±0  331 ✅ ±0  14 💤 ±0  0 ❌ ±0 
471 runs  ±0  457 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit a8413c8. ± Comparison against base commit c2e77b2.

This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 28, 2024

Linux Test Report

0 files   -  53  0 suites   - 60   0s ⏱️ - 27m 15s
0 tests  - 669  0 ✅  - 661  0 💤  - 7  0 ❌  - 1 
0 runs   - 670  0 ✅  - 662  0 💤  - 7  0 ❌  - 1 

Results for commit a8413c8. ± Comparison against base commit c2e77b2.

♻️ This comment has been updated with latest results.

docker/Dockerfile_offline Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
contrib/CMakeLists.txt Outdated Show resolved Hide resolved
contrib/rapidjson Outdated Show resolved Hide resolved
.gitmodules Show resolved Hide resolved
docker/Dockerfile_offline Outdated Show resolved Hide resolved
@vagetablechicken vagetablechicken changed the title Feat/offline with git submodule feat: offline with git submodule Mar 1, 2024
farmhash/src/farmhash.h Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
farmhash/CMakeLists.txt Outdated Show resolved Hide resolved
farmhash/CMakeLists.txt Outdated Show resolved Hide resolved
docker/openmldb-build.dockerfile Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@aceforeverd
Copy link
Collaborator

@QiChenX pls ensure all CIs pass

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.95%. Comparing base (c2e77b2) to head (a8413c8).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3787      +/-   ##
============================================
+ Coverage     74.93%   74.95%   +0.01%     
  Complexity      658      658              
============================================
  Files           738      739       +1     
  Lines        133155   133157       +2     
  Branches       1380     1380              
============================================
+ Hits          99782    99805      +23     
+ Misses        33069    33048      -21     
  Partials        304      304              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aceforeverd aceforeverd merged commit f35f26b into 4paradigm:main Mar 4, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build openmldb compiling and installing docker openmldb compile image or demo image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants