-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navicat support #3816
navicat support #3816
Conversation
1. mock `show character set` 2. mock `show collation` 3. mock `show engines` 4. mock multi query 5. mock `information_schema.ROUTINES` 6. define `please enter database first` error 7. mock select tables, select columns, select count union, create database query 8. fix IOException cause bug 9. mock `SHOW FULL TABLES WHERE Table_type != 'VIEW'`
1. fix mysql COM_INIT_DB bug 2. mock `show status` 3. mock `INFORMATION_SCHEMA.VIEWS` 4. skip table_id field of query `show table status` 5. sqlEngine support use database
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3816 +/- ##
=========================================
Coverage 40.70% 40.70%
Complexity 658 658
=========================================
Files 195 195
Lines 11514 11514
Branches 1380 1380
=========================================
Hits 4687 4687
Misses 6523 6523
Partials 304 304 ☔ View full report in Codecov by Sentry. |
SDK Test Report101 files ±0 101 suites ±0 2m 11s ⏱️ +4s Results for commit 1cbaefd. ± Comparison against base commit 73c5844. This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Linux Test Report 53 files 60 suites 28m 4s ⏱️ For more details on these failures, see this check. Results for commit 1cbaefd. ♻️ This comment has been updated with latest results. |
pls rebase after #3814 |
# Conflicts: # extensions/open-mysql-db/README.md # extensions/open-mysql-db/src/main/java/com/_4paradigm/openmldb/mysql/server/ServerConfig.java
DONE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)