Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select constant return empty value #3825

Merged
merged 7 commits into from Mar 27, 2024
Merged

Conversation

Matagits
Copy link
Collaborator

@Matagits Matagits commented Mar 22, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix the problem that when select constant data and then it will generate dataframe with one colume but not data, and add corresponding test code. And when sql expression contains cast expression to select constant in offline mode, it will throw exception.

  • What is the current behavior? (You can also link to an open issue here)
    Issue#3733. Select constant data will not return value row #3733
    Plus, when sql expression contains cast expression to select constant in offline mode, it will throw exception.

  • What is the new behavior (if this is a feature change)?
    When select constant data, it will generate dataframe with one row of corresponding constant data. And also support cast expression when select constant in offline mode.

@github-actions github-actions bot added the batch-engine openmldb batch(offline) engine label Mar 22, 2024
Copy link
Contributor

github-actions bot commented Mar 22, 2024

SDK Test Report

101 files  101 suites   2m 6s ⏱️
349 tests 335 ✅ 14 💤 0 ❌
475 runs  461 ✅ 14 💤 0 ❌

Results for commit 260a0d3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 22, 2024

Linux Test Report

    56 files     189 suites   1h 22m 48s ⏱️
12 619 tests 12 611 ✅ 7 💤 1 ❌
12 620 runs  12 612 ✅ 7 💤 1 ❌

For more details on these failures, see this check.

Results for commit 260a0d3.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 74.89%. Comparing base (6e45bec) to head (260a0d3).
Report is 1 commits behind head on main.

Files Patch % Lines
...radigm/openmldb/batch/nodes/ConstProjectPlan.scala 78.94% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3825       +/-   ##
=============================================
+ Coverage     40.69%   74.89%   +34.20%     
  Complexity      658      658               
=============================================
  Files           195      742      +547     
  Lines         11650   133786   +122136     
  Branches       1384     1379        -5     
=============================================
+ Hits           4741   100203    +95462     
- Misses         6605    33279    +26674     
  Partials        304      304               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub
Copy link
Collaborator

@aceforeverd aceforeverd merged commit 4c6406e into 4paradigm:main Mar 27, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch-engine openmldb batch(offline) engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants