-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: select constant return empty value #3825
Conversation
SDK Test Report101 files 101 suites 2m 6s ⏱️ Results for commit 260a0d3. ♻️ This comment has been updated with latest results. |
Linux Test Report 56 files 189 suites 1h 22m 48s ⏱️ For more details on these failures, see this check. Results for commit 260a0d3. ♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3825 +/- ##
=============================================
+ Coverage 40.69% 74.89% +34.20%
Complexity 658 658
=============================================
Files 195 742 +547
Lines 11650 133786 +122136
Branches 1384 1379 -5
=============================================
+ Hits 4741 100203 +95462
- Misses 6605 33279 +26674
Partials 304 304 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please resolve the cicd issue in https://github.com/4paradigm/OpenMLDB/actions/runs/8419907957/job/23053523375?pr=3825 . |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix the problem that when select constant data and then it will generate dataframe with one colume but not data, and add corresponding test code. And when sql expression contains cast expression to select constant in offline mode, it will throw exception.
What is the current behavior? (You can also link to an open issue here)
Issue#3733. Select constant data will not return value row #3733
Plus, when sql expression contains cast expression to select constant in offline mode, it will throw exception.
What is the new behavior (if this is a feature change)?
When select constant data, it will generate dataframe with one row of corresponding constant data. And also support cast expression when select constant in offline mode.