feat(open-mysql-db): refactor mock code #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 22, 2024 17:45
1. remove unnecessary instance var port 2. fix cause null bug 3. remove unnecessary throws 4. fix ctx.close() sequence bug 5. config sessionTimeout and requestTimeout 6. add docs of SqlEngine
yangwucheng
requested review from
tobegit3hub,
aceforeverd and
vagetablechicken
SDK Test Report101 files 101 suites 2m 12s ⏱️ Results for commit 17b691f. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3831 +/- ##
============================================
- Coverage 40.70% 40.69% -0.02%
Complexity 658 658
============================================
Files 195 195
Lines 11514 11650 +136
Branches 1380 1384 +4
============================================
+ Hits 4687 4741 +54
- Misses 6523 6605 +82
Partials 304 304 ☔ View full report in Codecov by Sentry. |
Linux Test Report 57 files 244 suites 1h 45m 3s ⏱️ Results for commit 17b691f. ♻️ This comment has been updated with latest results. |
aceforeverd
reviewed
Mar 25, 2024
| @@ -6,4 +6,6 @@ server.port=3307 | |||
| zookeeper.cluster=0.0.0.0:2181 | |||
| zookeeper.root_path=/openmldb | |||
| openmldb.user=root | |||
| openmldb.password=root | |||
| openmldb.password=4pdadmin | |||
There was a problem hiding this comment.
will this used with public server ?
aceforeverd
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
refactor mock codes
extracted some mock functions