Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping http://i.imgur.com/VpStI.jpg -- already attempted #29

Closed
tapabug opened this issue Apr 29, 2014 · 2 comments
Closed

Skipping http://i.imgur.com/VpStI.jpg -- already attempted #29

tapabug opened this issue Apr 29, 2014 · 2 comments

Comments

@tapabug
Copy link

tapabug commented Apr 29, 2014

This is not a bug, just a thing I think should be corrected:

I was downloading this:
goneabitwild.imgur.com
but this happened:

2014-04-29 16:48:37,953 22945 [pool-1-thread-2] INFO ripper.DownloadFileThread - Downloading file: http://i.imgur.com/VpStI.jpg
2014-04-29 16:48:38,347 23339 [pool-1-thread-2] INFO ripper.DownloadFileThread - [+] Saved http://i.imgur.com/VpStI.jpg as ./rips/imgur_goneabitwild/8OUfg/002_VpStI.jpg
2014-04-29 16:48:47,004 31996 [Thread-6] INFO ripper.AbstractRipper - [!] Skipping http://i.imgur.com/VpStI.jpg -- already attempted: ./rips/imgur_goneabitwild/KTOKb/003_VpStI.jpg

I don't think VpStI.jpg should be skipped in /a/KTOKb

thanks

@4pr0n
Copy link
Owner

4pr0n commented May 1, 2014

All rippers have de-dupe logic to avoid downloading the same URL twice -- this is because some extraction methods get the same URL twice. source

I'm pretty sure imgur extraction methods only get a single URL at a time, so it should be safe to remove the de-dupe logic.

@4pr0n
Copy link
Owner

4pr0n commented May 5, 2014

This was fixed in 535efb4

@4pr0n 4pr0n closed this as completed May 5, 2014
metaprime added a commit to metaprime/ripme-old that referenced this issue Aug 10, 2017
Eroshareripper now uses mirror for data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants