Add interlocking of send taskPerformer and SerialPortEventListener #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a sendPending flag
4refr0nt
added a commit
that referenced
this pull request
Dec 1, 2015
Add interlocking of send taskPerformer and SerialPortEventListener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent upgrade of NodeMCU firmware to SDK 1.4.0 in
devbranch changed the timing of the interactive command line interpreter. This triggered race conditions in ESPlorer's code which led to instabilities in "Send to ESP" eg.Specifically, I found the assumption "
timer.isRunning()is immediately true oncetimer.start()is issued" to be wrong sometimes. It happens from time to time thatPortExtraReader.serialEvent()is called again but the timer did not yet start. As a result, it will incrementjanother time without correct handshaking withActionListener. This randomly generates the case that one line is skipped and the next line is sent twice.This PR attempts to resolve such races between the ActionListener and the SerialPortEventListener by introducing the boolean flag
sendPending. It ensures that the SerialPortEventListener will not advance before the current line has been sent.