Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use freeze from ftw.testing in our tests. #31

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Conversation

mbaechtold
Copy link
Contributor

This pull requests makes testing of the default news date more robust.

@@ -9,3 +9,8 @@ auto-checkout =
ftw.simplelayout
# https://github.com/4teamwork/ftw.datepicker/pull/3
ftw.datepicker
# https://github.com/4teamwork/ftw.testing/pull/21
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚧

@mbaechtold
Copy link
Contributor Author

The test should be passing once there is a new release of forbiddenfruit and ftw.testing has been updated accordingly.

See 4teamwork/ftw.testing#23 and clarete/forbiddenfruit#14



[branches]
ftw.testing = jone-forbiddenfruit
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbaechtold merged 😉

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and released

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you @jone.

I've updated this pull request. The extras test now requires ftw.testing >= 1.11.0.

@mbaechtold
Copy link
Contributor Author

@jone, this is ready now!

@jone jone merged commit ca11fa2 into master Mar 31, 2016
@jone jone deleted the mba/use-freeze-in-test branch March 31, 2016 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants