Add possibility to set the pdf title via build arguments. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deiferni
suggested changes
Feb 22, 2017
ftw/pdfgenerator/assembler.py
Outdated
| if not filename: | ||
| filename = self.context.id | ||
|
|
||
| filename = '{}.{}'.format(filename, extension) |
There was a problem hiding this comment.
Nbeware, you'll run into an UnicodeError here if you supply unicode filename with umlauts for example.
Now i'm not sure how and if and which browsers support non ascii filenames, so i'd investigate that and cleary document what filename should be, and also add (if possible) a test with non-ascii characters.
There was a problem hiding this comment.
update, there is a filename* filename parameter for the content disposition:
https://tools.ietf.org/html/rfc6266#appendix-D and
https://tools.ietf.org/html/rfc6266#section-4.3
@jone do we have any experience with that?
phgross
force-pushed
the
pg_pdf_title
branch
from
18a59ce
to
ca4a06c
Compare
deiferni
approved these changes
Feb 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used for 4teamwork/opengever.core#2511