New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade only specified profiles. [feature request] #155

Closed
mauritsvanrees opened this Issue Jan 4, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@mauritsvanrees
Contributor

mauritsvanrees commented Jan 4, 2018

I like to run bin/upgrade install --site Plone --proposed to apply all pending upgrades for all profiles. But I now have a site where this fails, because one of the installed profiles has an upgrade from * to *, which means it is always available, which leads ftw.upgrade to think the upgrade failed. This is a problem in that specific profile (lineage.registry 1.3, fixed in version 1.3.1). So I know how to fix it in this case.

But before I saw where the problem was, I tried to say on the command line: only run the pending (proposed) upgrades of one or more (other) profiles. This is not possible. You can only specify a specific upgrade step: bin/upgrade install --site Plone --upgrades 3001@my.package:default.

I would instead like to say this:

bin/upgrade install --site Plone --upgrades my.package:default second.package:default

That would install all proposed upgrades for those two profiles. If no upgrades are proposed, it should finish without error.

Do you think this could be added?

@jone

This comment has been minimized.

Show comment
Hide comment
@jone

jone Jan 7, 2018

Member

This is a good idea, thanks for the input!

Only, I'd like to still use --proposed, not --upgrades, because I could interpret that --upgrades my.package:default installs all upgrades of this profile, even when they are already installed.
--proposed my.package:default on the other hand is clearer for me: it installs only the proposed upgrades of this profile.

I opened a pull request: #156
Feel free to review / comment 😉

Member

jone commented Jan 7, 2018

This is a good idea, thanks for the input!

Only, I'd like to still use --proposed, not --upgrades, because I could interpret that --upgrades my.package:default installs all upgrades of this profile, even when they are already installed.
--proposed my.package:default on the other hand is clearer for me: it installs only the proposed upgrades of this profile.

I opened a pull request: #156
Feel free to review / comment 😉

@hvelarde

This comment has been minimized.

Show comment
Hide comment
@hvelarde

hvelarde Jan 8, 2018

@idgserpro this feature looks interesting also.

hvelarde commented Jan 8, 2018

@idgserpro this feature looks interesting also.

@jone

This comment has been minimized.

Show comment
Hide comment
@jone

jone Jan 8, 2018

Member

This feature is implemented and released in ftw.upgrade = 1.10.0 🎉

Member

jone commented Jan 8, 2018

This feature is implemented and released in ftw.upgrade = 1.10.0 🎉

@jone jone closed this Jan 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment