Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests by adding ftw.calendar version constraint. #98

Open
wants to merge 2 commits into
base: master
from
Open

Conversation

@jone
Copy link
Member

jone commented Jan 14, 2020

ftw.workspace depends on ftw.meeting, which depends on ftw.calendar with a version constraint. ftw.meeting also depends directly on ftw.calendar without a version constraint. Since buildout does not have an intelligent dependency resolution this can lead to the problem that ftw.calendar was already picked in an incompatible version.

In order to fix that, we must provide a version pinning on buildout level.

Also fixes unittest imports.

Fixes 4teamwork/ogb#122

ftw.workspace depends on ftw.meeting, which depends on ftw.calendar with a version constraint.
ftw.meeting also depends directly on ftw.calendar without a version constraint.
Since buildout does not have an intelligent dependency resolution this can lead to the
problem that ftw.calendar was already picked in an incompatible version.

In order to fix that, we must provide a version pinning on buildout level.
@jone jone requested a review from 4teamwork/plone Jan 14, 2020
Copy link

djowett-ftw left a comment

Makes sense enough to me

@jone jone requested a review from djowett-ftw Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.