Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests by adding ftw.calendar version constraint. #98

Closed
wants to merge 2 commits into from

Conversation

jone
Copy link
Member

@jone jone commented Jan 14, 2020

ftw.workspace depends on ftw.meeting, which depends on ftw.calendar with a version constraint. ftw.meeting also depends directly on ftw.calendar without a version constraint. Since buildout does not have an intelligent dependency resolution this can lead to the problem that ftw.calendar was already picked in an incompatible version.

In order to fix that, we must provide a version pinning on buildout level.

Also fixes unittest imports.

Fixes https://github.com/4teamwork/ogb/issues/122

ftw.workspace depends on ftw.meeting, which depends on ftw.calendar with a version constraint.
ftw.meeting also depends directly on ftw.calendar without a version constraint.
Since buildout does not have an intelligent dependency resolution this can lead to the
problem that ftw.calendar was already picked in an incompatible version.

In order to fix that, we must provide a version pinning on buildout level.
@jone jone requested a review from a team January 14, 2020 07:26
Copy link

@djowett-ftw djowett-ftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense enough to me

@jone jone requested a review from djowett-ftw January 15, 2020 10:53
@jone jone closed this Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants