Bundle Import: Reduce memory footprint #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the Plone site using setSite(), and garbage collecting the cPickleCache.
lukasgraf
force-pushed
the
lg-bundle-memory-usage
branch
from
5cd9624
to
6a8f7d8
Compare
|
@phgross thise one is now ready, and tested again. |
phgross
added a commit
that referenced
this pull request
Aug 11, 2017
Bundle Import: Reduce memory footprint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes aim to reduce the memory (RSS) footprint of a bundle import, particularly the high-water-mark.
While I was able to clean up some leaking references in earlier pull requests (x, y), that wasn't enough to significantly bring down max. memory usage.
At some point I discovered that re-setting the Plone site using the
getSite()hook finally manages to get rid of those leaking references, and allows the Python garbage collector to do its job. In addition, thecPickleCachealso needs to be garbage collected periodically.So, in regular intervals the following things need to happen:
I can't yet say what exact impact the interval has, and whether this is the optimal order, but at least the first three need to happen in order to get a significant reduction in the memory high-water-mark.
Backported to:
2017.4-stable