Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added arabic README #109

Merged
merged 24 commits into from
Nov 9, 2023
Merged

Added arabic README #109

merged 24 commits into from
Nov 9, 2023

Conversation

eymeen
Copy link
Contributor

@eymeen eymeen commented Nov 6, 2023

No description provided.

@YasinDehfuli YasinDehfuli added the documentation Improvements or additions to documentation label Nov 9, 2023
@YasinDehfuli
Copy link
Member

Thanks Dear @eymeen.
You need to do some changes to improve your work:

  1. Add your Arabic Button in end of the list or next to English button.
  2. Don't translate the Arabic translate buttons and let it stay English like other pages.
  3. We need your full translate - please add steps-ar folder and translate all steps of arabic language too.

YasinDehfuli
YasinDehfuli requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@YasinDehfuli YasinDehfuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do these changes. And translate steps to Arabic too.

Good luck And see you soon dear @eymeen

README.ar.md Outdated

[![ar](https://img.shields.io/badge/Lang-العربية-black.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.ar.md)
                         
[![en](https://img.shields.io/badge/Lang-الإنجليزية-blue.svg)](https://github.com/4xmen/Get-Github-Achievements/blob/master/README.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change all buttons names to English.

README.ar.md Outdated

#### - إذا كنت بحاجة إلى المزيد من المساعدة ، انقر على زر "كيفية الحصول" للحصول على برنامج تعليمي خطوة بخطوة حول كيفية الحصول على هذا الإنجاز.

<div align="center"><a href="assets/steps/README.yolo.md"><img src="assets/img/btn.png" alt=""></a></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, please, Change the How to get button to Arabic for better interview

README.ar.md Outdated

#### - إذا كنت بحاجة إلى المزيد من المساعدة ، انقر على زر "كيفية الحصول" للحصول على برنامج تعليمي خطوة بخطوة حول كيفية الحصول على هذا الإنجاز.

<div align="center"><a href="assets/steps/README.yolo.md"><img src="assets/img/btn.png" alt=""></a></div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create steps-ar folder and translate all how to get steps to Arabic and link it in your Arabic main translate for complete your job.

README.ar.md Outdated
<br>

<div align="center">
<a href="assets/steps/README.galaxy-brain.md">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to link your steps-ar translate pages here too.

README.ar.md

####


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After add steps-ar and change fix bugs and do changes, we will see you as our contributions.

Thanks dear @eymeen.

See you soon as our contributors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done my man

YasinDehfuli
YasinDehfuli requested changes Nov 9, 2023
View reviewed changes
assets/btn-ar.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the btn-ar.png location to https://github.com/4xmen/Get-Github-Achievements/tree/main/assets/img

your btn-ar.png is currently in assets, move it to ⇉ assets/img file

@YasinDehfuli YasinDehfuli merged commit 91920ba into 4xmen:main Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YasinDehfuli YasinDehfuli YasinDehfuli requested changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eymeen @YasinDehfuli