Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android): upgrade readium android #38

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

adesege
Copy link
Contributor

@adesege adesege commented Jun 12, 2023

No description provided.

@jspizziri
Copy link
Contributor

@adesege friendly ping on this one. What's the status of this PR? What work remains to be completed on it.

@@ -0,0 +1,6 @@
#Mon Jun 12 23:30:00 WAT 2023
distributionBase=GRADLE_USER_HOME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seem like react-native files. Did you attempt to upgrade RN? If so that should all belong in the example project.

@@ -0,0 +1,234 @@
#!/bin/sh

#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@@ -0,0 +1,89 @@
@rem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

@jspizziri
Copy link
Contributor

I tested this and found that it currently doesn't build.

@casperolesen
Copy link

@jspizziri

Do you also get the 'Unable to load script. Make sure you're either running Metro or that you bundle 'index.android.bundle' is packaged correctly for release?

@jspizziri
Copy link
Contributor

@casperolesen I can't remember if I did or not. In any case, there's work needed on this to make it run.

@casperolesen
Copy link

I'm currently also trying to bump android, because it can't run in our current RN 0.72 setup.

yarn android --mode release seems to work

yarn android gives the error Unable to load script. Make sure you're either running Metro or that you bundle 'index.android.bundle' is packaged correctly for release

@jspizziri
Copy link
Contributor

@casperolesen I'm not sure if the issue you're talking about is specific to this branch or not? If it is, I'm not sure I'm able to help right now. If it's not, please create a reproduction off of main based on the example project and create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants