Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move weapon handling to an external file #23

Open
8 of 14 tasks
50Wliu opened this issue Feb 26, 2014 · 1 comment
Open
8 of 14 tasks

Move weapon handling to an external file #23

50Wliu opened this issue Feb 26, 2014 · 1 comment
Assignees
@50Wliu
Labels
enhancement in-progress
Milestone
2.0.0

Comments

@50Wliu
Copy link
Member

50Wliu commented Feb 26, 2014

This was planned a long time ago but apparently nobody had time to do it.
File should be something like ff2_weapons.txt weapons.cfg in addons/sourcemod/configs/freak_fortress_2/.

  • Implement "By Classname"
    • Implement "name" (this will allow us to filter out weapons we don't want to match)
      • Possibly get rid of this and create include/exclude keys instead?
  • Implement "By Definition Index"
  • Implement "replace"
  • Implement "removeattribs" - renamed to "remove"
    • Allow specifying attributes through their attrib name, not id
    • Provide a way to easily remove all attributes
  • Implement "addattribs" - renamed to "add"
    • Allow specifying attributes through their attrib name, not id
  • Implement "onhit"
  • Implement "ontakedamage"
  • Cleanup existing weapon code
  • Generate full weapon config
@50Wliu 50Wliu added this to the FUTURE milestone Feb 26, 2014
@50Wliu 50Wliu self-assigned this Feb 26, 2014
@50Wliu 50Wliu modified the milestones: 2.0.0, FUTURE Mar 8, 2014
50Wliu added a commit that referenced this issue Mar 31, 2014
@50Wliu
Added BBG_Theory's suggestion
cf5740c 
-Also, some forward thinking™ for #23
50Wliu added a commit that referenced this issue May 12, 2014
@50Wliu
Getting some work done
516124d 
-Made errors a bit more precise
-Minor weapon config work (#23)
-(Kinda) started changelog work (#5)
@50Wliu 50Wliu removed the in-progress label Aug 1, 2014
50Wliu added a commit that referenced this issue Sep 17, 2015
@50Wliu
More weapon config work!
db413e1 
- Get rid of "By Classname" and "By Definition Index", just merge the
two together to make it simpler
- Rewrite "remove" and "add" now that I think I know more of what I'm
doing

Refs #23
@50Wliu
Copy link
Member Author

50Wliu commented Sep 17, 2015

By Classname and By Definition Index have been removed and now everything is unified. FF2 should be smart enough to tell whether you're specifying a classname or index (I mean, one's a number and one's a string...). Replace, remove, and add are theoretically functional (at least the basics), though that's probably not the case in-game...

50Wliu added a commit that referenced this issue Sep 18, 2015
@50Wliu
Make "remove" a section again
89c898c 
This helps prevent two things:
* TF2Attributes complaining if 'remove' didn't exist (could be easily
prevented by a null check, but eh)
* Variable shadowing

Should also make the weapon config code more consistent.

Refs #23
50Wliu added a commit that referenced this issue Sep 18, 2015
@50Wliu
Implement support for removing all attributes
c9f4226 
Refs #23
50Wliu added a commit that referenced this issue Sep 26, 2015
@50Wliu
Add support for specifying the attrib name instead of index
1e4d1f7 
Refs #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@50Wliu 50Wliu

Labels
enhancement in-progress
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@50Wliu