Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key bindings not working on Firefox #248

Closed
huguesdk opened this issue Mar 22, 2018 · 2 comments
Closed

Key bindings not working on Firefox #248

huguesdk opened this issue Mar 22, 2018 · 2 comments

Comments

@huguesdk
Copy link
Contributor

Environment

  • Browser: Firefox
  • Browser Version: 55.0.2
  • Operating System: GNU/Linux
  • Amplitude.js Version: 3.2.3

Issue description

Key bindings don’t work in Firefox, and pressing any key produces a "ReferenceError: event is not defined" error.

Steps to reproduce the issue

  1. Open a page with AmplitudeJS loaded in Firefox.
  2. Press any key on the keyboard.
  3. Check the console for an error message.

What is expected?

No error occurs, and configured key bindings work.

Link to where issue can be reproduced

JS Bin testcase
@huguesdk huguesdk mentioned this issue Mar 22, 2018
Merged
@Bagera
Copy link
Contributor

Bagera commented Apr 6, 2018

Same error in FF on Win10

danpastori added a commit that referenced this issue Jun 13, 2018
@danpastori
Fixed event handlers in Firefox. References #248
ad2772c
@danpastori
Copy link
Contributor

This is fixed in the Dev branch, I didn't pass the event to the handler: https://github.com/521dimensions/amplitudejs/tree/dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@huguesdk @danpastori @Bagera