Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change from_udp_host to create UDP socket in non-blocking mode by default #14

Closed
56quarters opened this issue Jul 15, 2016 · 1 comment
Closed

Change from_udp_host to create UDP socket in non-blocking mode by default #14

56quarters opened this issue Jul 15, 2016 · 1 comment
Assignees
@56quarters
Labels
enhancement
Milestone
0.6.0

Comments

@56quarters
Copy link
Owner

Like it says, if we create a socket in StatsdClient::from_udp_host, create it in non-blocking mode. We could also potentially support some sort of config object here to pass in. But, I don't think that's really needed since callers can always just use the StatsdClient::from_sink method for more control.
@56quarters 56quarters added this to the 0.6.0 milestone Jul 15, 2016
@56quarters 56quarters self-assigned this Jul 15, 2016
@56quarters 56quarters mentioned this issue Jul 17, 2016
Closed
@56quarters
Copy link
Owner Author

56quarters commented Jul 19, 2016 •
edited
Loading

TODO:

  • Update the actual code in StatsdClient::from_udp_host
  • Update StatsdClient::from_udp_host docs to indicate that sockets are created in non-blocking mode
  • Update UdpMetricSink::from docs to indicate that the non-blocking example is done by default in StatsdClient::from_udp_host
  • Update lib.rs and README.md to indicate that sockets are created in non-blocking mode (maybe remove that section about creating a non-blocking socket?)
  • Change tests to just use from_udp_host and remove the non-blocking special cases

56quarters added a commit that referenced this issue Jul 20, 2016
@56quarters
Set UDP sockets created by StatsdClient::from_udp_host to non-blockin…
9528b11 
…g mode

Create UDP sockets in non-blocking mode by default. This should result in
a minimal behavior change for callers of the library. Callers wishing to
restore the old behavior (blocking) can do so by creating a custom
UdpMetricSink instance.

Fixes #14
56quarters added a commit that referenced this issue Jul 20, 2016
@56quarters
Set UDP sockets created by StatsdClient to non-blocking mode
083c2aa 
Create UDP sockets in non-blocking mode by default. This should
result in a minimal behavior change for callers of the library.
Callers wishing to restore the old behavior (blocking) can do so
by creating a custom UdpMetricSink instance.

Fixes #14
@56quarters 56quarters mentioned this issue Jul 20, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@56quarters 56quarters

Labels
enhancement
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
1 participant
@56quarters