Investigate buffered MetricSink implementation #18
Comments
|
Since this buffered sink will be mutable (or the wrapped data structure will be) it'll have to use locking around any critical sections. |
|
The underlying writer used by the metric sink will probably end up being similar to LineWriter or BufWriter. |
|
In the interest of incremental work, this issue will only cover introducing a buffer. There will be another issue / PR for moving network calls to a separate thread ala threadpool. Both of these things will have to be completed for the 0.8.0 release |
56quarters
added a commit
that referenced
this issue
Aug 6, 2016
New MetricSink implementation that buffers metrics sent to it up to a certain size (user configurable) before sending via a UDP socket. Each metric is written to a shared (mutex guarded) buffer along with a trailing newline (\n). When the buffer cannot fit the next metric, it will be flushed. Metrics that are too large for the buffer (unlikely but possible) will be written directly to the underlying socket. Current limitations: * Mutex poisoning is not handled. It has the potential to panic the thread. * Metrics are still written to the socket in the calling thread. Fixes #18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per Statsd docs, it's possible to batch up metrics before sending. See if we can introduce some primitive in Cadence that makes this easy to do. Maybe a buffered sink that wraps another sink?
The text was updated successfully, but these errors were encountered: