-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose network-level telemetry #196
Comments
Where are the "dropped" counters coming from? Implicit when there's an error writing to a socket?
Adding a new method to
Seems like a nice addition to me. Thanks for the issue! |
Yea, that was my initial though on it. In theory wrapping sink could have some retry logic (I don't think it's the case currently) so error writing to a socket won't necessary mean that data got dropped on the floor but maybe it would be good enough for start. If sinks would return
Right, I can try to prototype it in upcoming days and then we'll see how it looks. Maybe implementing it for few low-level sinks would be just fine and wrapping sink can simply call
Thanks, let me try to come up with some draft and we can further discuss direction over there. |
@56quarters initial stub on #203. This only exposes bytes / packets sent in some parts. Should be enough to discuss on further direction. |
Fixed by #196. |
While working with bigger numbers of metrics being emitted it's useful to know things like:
in order to e.g. diagnose issues related agent receiving those being hammered. Currently there isn't anything like this from what I've checked -
QueuingMetricSink
supports few metrics viaWorkerStats
but those are related to the queue / channel being used there.One option would be to have those at the very low layers like
UnixWriteAdapter
orUdpWriteAdapter
but then we would need to have an API to access those:MetricSink
trait with something likestats()
to get access those. Wrapping sinks would simply callstats()
of the underlying sink.BufferedUnixMetricSink
andUnixWriteAdapter
and in a similar manner for UDPAny thoughts / ideas?
The text was updated successfully, but these errors were encountered: