Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated stdlib calls and establish minimum Rust version #80

Closed
56quarters opened this issue Feb 13, 2019 · 2 comments
Closed

Comments

@56quarters
Copy link
Owner

There are a number of warnings emitted now (1.33.0-nightly) about use of things in the standard library that are deprecated.

Instead of just replacing them, establish the minimum version of Rust required to use Cadence and document it. Perhaps establish a policy of supporting $current - 2 releases or something. Only once the minimum version is documented can we move on to replacing the deprecated methods.

@56quarters
Copy link
Owner Author

56quarters commented Feb 27, 2019

Results of running cargo test, cargo test -- --ignored, and cargo bench with various versions of Rust (2015 edition) with da9f98e of Cadence.

Commands

rustup run $ver cargo test
rustup run $ver cargo test -- --ignored

Results

  • 1.24.0 - fail, u128 used by crossbeam unstable
  • 1.25.0 - fail, u128 used by crossbeam unstable
  • 1.26.0 - pass
  • 1.27.0 - pass
  • 1.28.0 - pass
  • 1.29.0 - pass
  • 1.30.0 - pass
  • 1.31.0 - pass
  • 1.32.0 - pass

@56quarters
Copy link
Owner Author

Closing this for now. The replacement for the deprecated calls that prompted this ticket was not introduced until 1.30 and so we can't replace them until we drop support for 1.29 which will be a little while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant