Request permission for getting GPSI (Consumption Reporting - Generating the reportingClientId #57) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsilhavy
requested changes
Dec 6, 2023
There was a problem hiding this comment.
@shilinding Please check my comments and adjust the implementation accordingly
..._5GMSdAwareApplication/app/src/main/java/com/fivegmag/a5gmsdawareapplication/MainActivity.kt
Outdated
Show resolved
Hide resolved
..._5GMSdAwareApplication/app/src/main/java/com/fivegmag/a5gmsdawareapplication/MainActivity.kt
Outdated
Show resolved
Hide resolved
dsilhavy
requested changes
Dec 7, 2023
| var needReqPermission: Boolean = false | ||
| var idx: Int = 0 | ||
| val permissions = arrayOf( | ||
| Manifest.permission.ACCESS_FINE_LOCATION, |
There was a problem hiding this comment.
I also intend to implement so before, but I don't know Android support empty array .
Done
..._5GMSdAwareApplication/app/src/main/java/com/fivegmag/a5gmsdawareapplication/MainActivity.kt
Outdated
Show resolved
Hide resolved
..._5GMSdAwareApplication/app/src/main/java/com/fivegmag/a5gmsdawareapplication/MainActivity.kt
Outdated
Show resolved
Hide resolved
..._5GMSdAwareApplication/app/src/main/java/com/fivegmag/a5gmsdawareapplication/MainActivity.kt
Outdated
Show resolved
Hide resolved
added 2 commits
December 8, 2023 17:44
…use dynamic array)
…aviod 3 warnings)
dsilhavy
pushed a commit
that referenced
this pull request
Mar 15, 2024
…der #51 (#37) * test first commit * * Consumption Reporting - Generating the reportingClientId-issue #57: GPSI * Consumption Reporting - Request permission for getting GPSI #33 * Consumption Reporting - Request permission for getting GPSI #33 * Consumption Reporting - Request permission for getting GPSI #33(use dynamic array) * Consumption Reporting - Request permission for getting GPSI #33(aviod 3 warnings) * Support for the expires header #51: support default timer period value be configured in configuration file; refactor code * Support for the expires header #51: move default timer configuration file to Media Session Handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35