Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): Optimized workflows to build images based on file changes #119

Merged
merged 2 commits into from
May 24, 2024

Conversation

anurag-rajawat
Copy link
Collaborator

@anurag-rajawat anurag-rajawat commented May 22, 2024

Description

This PR improves our CI & CD pipeline by:

  • Adding dependabot.yml to automate dependency updates.
  • Building and pushing container images only when relevant files change.
  • Introducing two types of container images:
    • Versioned Images (e.g., v0.1): These images are released as part of stable releases.
    • Latest Images: These images are built and pushed whenever changes are made to the main branch.
  • Adding a grype image scanning job to detect vulnerabilities in container images.

Does this PR introduce a breaking change?
No.

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

@anurag-rajawat anurag-rajawat marked this pull request as draft May 22, 2024 15:06
@VedRatan
Copy link
Collaborator

@anurag-rajawat you need to update the nimbus image version here so that the versioned image is being pushed in kind cluster, else kind cluster will be unable to find the image, similarly do that for nimbus-kubearmor nimbus netpol nimbus-kyverno adapter's images

@anurag-rajawat anurag-rajawat marked this pull request as ready for review May 22, 2024 16:21
@anurag-rajawat
Copy link
Collaborator Author

@VedRatan thank you very much for saving my time.

VedRatan
VedRatan previously approved these changes May 22, 2024
Copy link
Collaborator

@VedRatan VedRatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nandhued nandhued added this to the 5/31/24 milestone May 23, 2024
Signed-off-by: Anurag Rajawat <anurag@accuknox.com>
Signed-off-by: Anurag Rajawat <anurag@accuknox.com>
@VedRatan
Copy link
Collaborator

LGTM merging it now. Thanks @anurag-rajawat

@VedRatan VedRatan merged commit d632520 into 5GSEC:main May 24, 2024
11 checks passed
@anurag-rajawat anurag-rajawat deleted the fix-ci branch May 27, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants