Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Add build image job for PR checks #20

Merged
merged 2 commits into from
Dec 19, 2023
Merged

feat(ci): Add build image job for PR checks #20

merged 2 commits into from
Dec 19, 2023

Conversation

anurag-rajawat
Copy link
Collaborator

Description

Fix the docker-buildx target to fail with an error if the build fails. Additionally, add a new job to the PR checks that builds the operator's docker image to ensure it can be built successfully before merging the PR.

Fixes # (issue)

Does this PR introduce a breaking change?
No

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

First merge this PR because it has a commit to fix the Dockerfile

Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
@shivaccuknox shivaccuknox merged commit 0c87dfe into 5GSEC:main Dec 19, 2023
5 checks passed
@anurag-rajawat anurag-rajawat deleted the fix-make-ci branch December 19, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants