feat: Add owner reference linkage for adapter policy and strict mode handling #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+100
to
+111
| allStrictIntentsImplemented := true | ||
| for _, rule := range np.Spec.NimbusRules { | ||
| if rule.Rule.Mode == "strict" && !idpool.IsIdSupported(rule.ID) { | ||
| allStrictIntentsImplemented = false | ||
| logger.Info("The adapter does not support the strict mode intent", "ID", rule.ID) | ||
| break | ||
| } | ||
| } | ||
|
|
||
| // If there is any unimplemented strict mode intent, skip processing the NimbusPolicy. | ||
| if !allStrictIntentsImplemented { | ||
| logger.Info("Skipping NimbusPolicy processing.", "NimbusPolicy.Name", npName, "NimbusPolicy.Namespace", npNamespace) |
There was a problem hiding this comment.
If an adapter doesn't fully support strict mode for some SecurityIntents, then for those Intents, it will either skip them, resulting in no corresponding adapter policy or generate a best-effort policy.
But we shouldn't skip the whole NimbusPolicy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Add owner reference linkage and strict mode handling
Does this PR introduce a breaking change?
Checklist
<type>: <description>conventionAdditional information for reviewer
Mention if this PR is part of any design or a continuation of previous PRs