Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Handle SecurityIntent update and deletion #73

Merged
merged 3 commits into from
Mar 5, 2024
Merged

fix(core): Handle SecurityIntent update and deletion #73

merged 3 commits into from
Mar 5, 2024

Conversation

anurag-rajawat
Copy link
Collaborator

Description

Fixes #68

Does this PR introduce a breaking change?
No

Checklist

  • PR title follows the <type>: <description> convention
  • I use conventional commits in my commit messages
  • I have updated the documentation accordingly
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

Additional information for reviewer

Mention if this PR is part of any design or a continuation of previous PRs

@anurag-rajawat
fix(core): Handle SecurityIntent update and deletion
6eb1a59 
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
@anurag-rajawat
tests(core): Add tests for SecurityIntent update and deletion
5d342a7 
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
@anurag-rajawat
fix(adapters): Handle Policies on SecurityIntent update and deletion
4e5b0a8 
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
@seungsoo-lee seungsoo-lee merged commit 359d519 into 5GSEC:main Mar 5, 2024
8 checks passed
@anurag-rajawat anurag-rajawat deleted the feat-si-ops branch March 5, 2024 04:34
@anurag-rajawat anurag-rajawat mentioned this pull request Mar 5, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seungsoo-lee seungsoo-lee seungsoo-lee approved these changes

@shivaccuknox shivaccuknox Awaiting requested review from shivaccuknox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core]: Handle SecurityIntent update and deletion
2 participants
@anurag-rajawat @seungsoo-lee