Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RouteHandler recovery #42

Merged
merged 1 commit into from
Jul 4, 2018
Merged

RouteHandler recovery #42

merged 1 commit into from
Jul 4, 2018

Conversation

ViaoV
Copy link
Contributor

@ViaoV ViaoV commented Jul 4, 2018

Scopes will recover when a RouteHandler panics and present a 500 response. While in a DEV environment the data of the response will be populated will a full stack trace of the panic and the Error is populated with the panic message.

Internally this uses Context.Fail so in PROD environments the error and data will not be present.

Resolves #20

@ViaoV ViaoV added the enhancement New feature or request label Jul 4, 2018
@ViaoV ViaoV added this to the Initial Stable Release milestone Jul 4, 2018
@ViaoV ViaoV added this to In progress in Intial Release via automation Jul 4, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 122

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 81.495%

Totals Coverage Status
Change from base Build 120: 0.2%
Covered Lines: 458
Relevant Lines: 562

💛 - Coveralls

@ViaoV ViaoV merged commit cea1a8e into master Jul 4, 2018
Intial Release automation moved this from In progress to Done Jul 4, 2018
@ViaoV ViaoV deleted the recover branch July 4, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants