Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested scopes are now checked before routes #58

Merged
merged 2 commits into from
Jul 30, 2018
Merged

Conversation

ViaoV
Copy link
Contributor

@ViaoV ViaoV commented Jul 29, 2018

Nested scopes are now checked for route matches before individual routes
in the current scope. This was done to allow the "longest" match to
succeed and prevent wildcard routes from catching a route that would
otherwise be completed by a nested route.

Closes #57

Nested scopes are now checked for route matches before individual routes
in the current scope. This was done to allow the "longest" match to
succeed and prevent wildcard routes from catching a route that would
otherwise be completed by a nested route.
@coveralls
Copy link

coveralls commented Jul 29, 2018

Pull Request Test Coverage Report for Build 188

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 83.299%

Files with Coverage Reduction New Missed Lines %
route.go 2 96.3%
Totals Coverage Status
Change from base Build 184: 0.1%
Covered Lines: 798
Relevant Lines: 958

💛 - Coveralls

LocaLPath routes would match directories and then fail to deliver files.
@ViaoV ViaoV added this to In progress in Intial Release via automation Jul 30, 2018
@ViaoV ViaoV added this to the Initial Stable Release milestone Jul 30, 2018
@ViaoV ViaoV merged commit 16886a0 into master Jul 30, 2018
Intial Release automation moved this from In progress to Done Jul 30, 2018
@ViaoV ViaoV deleted the deep-scope-route-priority branch July 30, 2018 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants