Skip to content

Commit

Permalink
io/ratelimit: add test
Browse files Browse the repository at this point in the history
  • Loading branch information
5aaee9 committed Jun 30, 2023
1 parent 8d03b71 commit 9f2e6b9
Show file tree
Hide file tree
Showing 3 changed files with 109 additions and 1 deletion.
10 changes: 9 additions & 1 deletion pkgs/io/ratelimit/limiter.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func NewLimiter(size uint64) *Limiter {
}
}

// WaitToTake allow you take data
// Wait allow you take data
func (l *Limiter) Wait(size uint64) {
var s uint64
s = size
Expand Down Expand Up @@ -58,3 +58,11 @@ func (l *Limiter) Try(size uint64) (ok bool, remainingCount uint64, waitTime tim
l.now += reamining
return false, size - reamining, l.duration - now.Sub(l.last)
}

// reset internal for test only
func (l *Limiter) reset() {
l.lock.Lock()
defer l.lock.Unlock()

l.now = 0
}
File renamed without changes.
100 changes: 100 additions & 0 deletions pkgs/io/ratelimit/readwrite_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
package ratelimit

import (
"io"
"sync/atomic"
"testing"
"time"

"github.com/stretchr/testify/assert"
)

type dummyReadWriter struct {
closed atomic.Bool
}

func (r *dummyReadWriter) Close() error {
r.closed.Store(true)
return nil
}

func (r *dummyReadWriter) Read(p []byte) (int, error) {
if r.closed.Load() {
return 0, io.ErrUnexpectedEOF
}

return 1, nil
}

func (r *dummyReadWriter) Write(p []byte) (int, error) {
if r.closed.Load() {
return 0, io.ErrUnexpectedEOF
}

return 1, nil
}

func TestRateLimitReadWriteCloserRead(t *testing.T) {
data := make([]byte, 1024)
limit := 1024
limited := NewRateLimitReaderWriterCloser(&dummyReadWriter{}, uint64(limit))

start := time.Now()
for i := 0; i < limit; i++ {
_, err := limited.Read(data)
assert.NoError(t, err)
}

if time.Now().Sub(start) >= time.Second {
t.Error("The limiter blocked when it shouldn't have")
}

_, _ = limited.Read(data)

if time.Now().Sub(start) <= time.Second {
t.Error("The limiter didn't block when it should have")
}
}

func TestRateLimitReadWriteCloserWrite(t *testing.T) {
data := make([]byte, 1024)
limit := 1024
limited := NewRateLimitReaderWriterCloser(&dummyReadWriter{}, uint64(limit))

start := time.Now()

limited.(*RateLimitReadWriteCloser).limiter.reset()

for i := 0; i < limit; i++ {
_, err := limited.Write(data)
assert.NoError(t, err)
}

_, _ = limited.Write(data)

if time.Now().Sub(start) <= time.Second {
t.Error("The limiter didn't block when it should have")
}
}

func TestRateLimitReadWriteCloserReadAndWrite(t *testing.T) {
data := make([]byte, 1024)
limit := 1024
limited := NewRateLimitReaderWriterCloser(&dummyReadWriter{}, uint64(limit))

start := time.Now()

for i := 0; i < limit; i++ {
var err error
if i%2 == 0 {
_, err = limited.Read(data)
} else {
_, err = limited.Write(data)
}
assert.NoError(t, err)
}

if time.Now().Sub(start) >= time.Second {
t.Error("The limiter blocked when it shouldn't have")
}
}

0 comments on commit 9f2e6b9

Please sign in to comment.