Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Support Safe Apps SDK Promisified API #1593

Closed
mmv08 opened this issue Nov 12, 2020 · 2 comments
Closed

Support Safe Apps SDK Promisified API #1593

mmv08 opened this issue Nov 12, 2020 · 2 comments
Labels
Feature 👑 New functionality

Comments

@mmv08
Copy link
Member

mmv08 commented Nov 12, 2020

What is this feature about? (1 sentence)

Supporting V2 of the SDK which introduces promise-based API.

Why is it needed? What is the value? For whom do we build it?

To enhance the developer experience

Corresponding SDK issue: safe-global/safe-apps-sdk#58

@tschubotz tschubotz added Feature 👑 New functionality and removed Feature 👑 New functionality labels Nov 12, 2020
mmv08 added a commit that referenced this issue Dec 11, 2020
* use multiple versions of safe apps sdk

* use multiple versions of safe apps sdk

* Type fixes

* wip error for multiple versions

* fix multiple sdk versions

* app communicator wip

* communicator wip

* getEnvInfo handler

* update sdk

* app communicator wip

* sdk dep bump

* promisified getSafeInfo

* sendTransactions handler wip

* don't send a response if a handler doesnt return anything

* add handler for transaction sending

* wip rpc call handler

* rpc handler

* rpc handler fix

* V2 Communicator

* remove tsbuildinfo

* fix communicator

* fix error handling for rpc requests

* rpc call fixes

* Update sdk

* Adapting app to use formatters wip

* use messafe formatter from sdk

* Sdk update

* update safe apps sdk version, remove ethBalance from response for safe apps sdk v1

* bump sdk to beta version

* update yarn.lock

* update yarn.lock

* update yarn.lock

* use beta version of the sdk

* enhance validation check

* update dependecies

* Update to python3 dependencies

* Revert "Update to python3 dependencies"

This reverts commit 1332940.

* fix transaction params type import

Co-authored-by: Daniel Sanchez <daniel.sanchez@gnosis.pm>
@mmv08
Copy link
Member Author

mmv08 commented Dec 11, 2020

@tschubotz could we include this for some release?

@tschubotz
Copy link
Member

Seems like the PR is already merged, right? (#1594)
Then I think this will be in the 2.17.0 release next week, already, right @dasanra?

@tschubotz tschubotz added the Feature 👑 New functionality label Dec 11, 2020
@dasanra dasanra closed this as completed Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature 👑 New functionality
Projects
None yet
Development

No branches or pull requests

3 participants