Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

[Bug] Transaction is sent to backend even if not signed. #1656

Closed
dasanra opened this issue Nov 26, 2020 · 0 comments · Fixed by #1672
Closed

[Bug] Transaction is sent to backend even if not signed. #1656

dasanra opened this issue Nov 26, 2020 · 0 comments · Fixed by #1672
Assignees
@Agupane
Labels
Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases.

Comments

@dasanra
Copy link
Collaborator

dasanra commented Nov 26, 2020

Title/Description

Transaction is sent to backend even if the user doesn't sign it

Environment

  • Browser: All
  • Safe: All
  • Wallet: All
  • App Version: v2.15.1
  • Environment: All
    • dev (rinkeby)
    • staging (rinkeby)
    • production (mainnet)

Steps to reproduce

  1. Using a Metamask owner
  2. Create any type of transaction, a basic transfer can fit
  3. Go through until Metamask window is open
  4. Cancel the transaction in Metamask

Expected result

If transaction is not signed in Metamask the whole transaction should be canceled and shouldn't continue further

Obtained result

Transaction is sent to backend without any signature and backend rejects it

Screenshots

Captura de pantalla de 2020-11-26 16-20-28.png
@dasanra dasanra added Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases. labels Nov 26, 2020
@Agupane Agupane mentioned this issue Nov 30, 2020
Merged
dasanra pushed a commit that referenced this issue Dec 9, 2020
@Agupane
(Feature) - #1656 Tx is sent to backend even if not signed (#1672)
9175552 
* Fix black notification

* Fix executing tx even if the user rejected it

* Fix hidden metamask error code

* Fix proccessTransaction notifications and metamask sign reject handling
@dasanra dasanra mentioned this issue Dec 14, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Agupane Agupane

Labels
Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Feature) - #1656 Tx is sent to backend even if not signed 5afe/safe-react
2 participants
@Agupane @dasanra