This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 360
Refactor create/processTransaction
#3239
Merged
Merged
Changes from 21 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b1e83ab
Chore: break down createTransaction
katspaugh adb7e16
Notifications
katspaugh 83dacbb
chore: Don't destructure props
iamacook be38da0
chore: Continued refactor `createdTransaction`
iamacook 55572f6
Refactor more
katspaugh ac5b0cc
chore: Refactor processTx + cleanup createTx
iamacook 5a9d04c
fix: Lint
iamacook 4148f27
chore: Remove unreachable error handling
iamacook 02d013a
Fix process
katspaugh 94f42bc
Merge create and process tx
katspaugh 1598d95
Pull from dev
katspaugh cb61fe5
Custom nonce or recommended nonce
katspaugh d04bce3
Exit when no wallet connection
katspaugh b700598
Adjust processTx
katspaugh 095142c
Return null in getContractErrorMessage
katspaugh 9901d58
Pull from dev
katspaugh b8b4b33
Don't propose when executing with sigs (see #3269)
katspaugh 3b8af8b
chore: safeInstance as public field + rename arg
iamacook 44c16dc
fix: Update status
iamacook c6025b0
fix: Use safeInstance from this
iamacook 3c93788
build: Instantiate TxSender with every transaction
iamacook 7927ac0
chore: Improve error logging
iamacook 502dc57
chore: Add further error logging
iamacook ab04b9d
Merge branch 'dev' into refactor-tx-fns
iamacook File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,7 @@ enum ErrorCodes { | |
_614 = '614: Error fetching transaction by id', | ||
_615 = '615: Failed to retrieve last transaction from server', | ||
_616 = '616: Failed to retrieve recommended nonce', | ||
_617 = '617: Error fetching safeTxGas', | ||
_700 = '700: Failed to read from local/session storage', | ||
_701 = '701: Failed to write to local/session storage', | ||
_702 = '702: Failed to remove from local/session storage', | ||
|
@@ -47,6 +48,7 @@ enum ErrorCodes { | |
_811 = '811: Error calculating ERC721 transfer data for adding a Safe owner', | ||
_812 = '812: Error calculating ERC721 transfer data for removing a Safe owner', | ||
_813 = '813: Error calculating ERC721 transfer data for replacing a Safe owner', | ||
_814 = '814: Error performing an offline tx signature', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: it's not offline but off-chain |
||
_900 = '900: Error loading Safe App', | ||
_901 = '901: Error processing Safe Apps SDK request', | ||
_902 = '902: Error loading Safe Apps list', | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to double-check if we're hiding the error on purpose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, this was causing the app to crash. It was being handled incorrectly and couldn't be decoded. @katspaugh, can you confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we weren't handling this in any special way because it's not critical and there's no good recovery strategy. Other than logging, which is a good move.