-
Notifications
You must be signed in to change notification settings - Fork 360
Remove unnecessary transaction proposal #3269
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
} | ||
|
||
dispatch(fetchTransactions(chainId, safeAddress)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need to fetch transactions immediately if it was an execution because it will take time for the indexer to pick up the transaction. So the minimum would be the block time (10s).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katspaugh and I are in the process of doing a huge refactor of this and it is already removed there, but I'll add it here for good measure.
Pull Request Test Coverage Report for Build 1678175832
💛 - Coveralls |
Deployment links
|
E2E Tests Failed Failed tests:
|
Works fine for me. I don't have the same error in the console that it was reported. |
What it solves
Resolves #3261
How this PR fixes it
Transactions need only be proposed if it is not immediately executing. The unnecessary proposal has been removed.
How to test it