This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 360
Feature: Add ens domain to provider info #3281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Assistant Lite All Contributors have signed the CLA. |
iamacook
approved these changes
Jan 11, 2022
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 1713322718
💛 - Coveralls |
The logic is solid but this still needs the deployment of the Core SDK ENS resolution to build successfully. |
katspaugh
changed the title
build: Add ens domain to provider info
Feature: Add ens domain to provider info
Jan 11, 2022
katspaugh
reviewed
Jan 11, 2022
Deployment links
|
E2E Tests Failed Failed tests:
|
mmv08
reviewed
Jan 12, 2022
katspaugh
reviewed
Jan 14, 2022
katspaugh
reviewed
Jan 14, 2022
katspaugh
approved these changes
Jan 14, 2022
I tried by connecting a user with MM that has a ENS name "francotest.eth" but I don't see the name. I'm trying this on Rinkeby ENS name: "francotest.eth" |
…rovider # Conflicts: # package.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3231
How this PR relates to it
ENS Resolution when adding a provider
How to test it
ensDomain
in reduxproviders
Screenshots