Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Feature: Add ens domain to provider info #3281

Merged
merged 9 commits into from
Jan 18, 2022

Conversation

usame-algan
Copy link
Member

Relates to #3231

How this PR relates to it

ENS Resolution when adding a provider

How to test it

  • Open the Safe
  • Connect a wallet that has a registered ENS domain
  • Observe ensDomain in redux providers

Screenshots

Screenshot 2022-01-11 at 12 40 32

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 11, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

coveralls commented Jan 11, 2022

Pull Request Test Coverage Report for Build 1713322718

  • 7 of 43 (16.28%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 32.453%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/logic/wallets/getWeb3.ts 1 16 6.25%
src/logic/wallets/store/middlewares/providerWatcher.ts 6 27 22.22%
Totals Coverage Status
Change from base Build 1712914245: -0.04%
Covered Lines: 3163
Relevant Lines: 8699

💛 - Coveralls

@iamacook
Copy link
Member

The logic is solid but this still needs the deployment of the Core SDK ENS resolution to build successfully.

@katspaugh katspaugh changed the title build: Add ens domain to provider info Feature: Add ens domain to provider info Jan 11, 2022
@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@github-actions
Copy link

github-actions bot commented Jan 11, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1697756743

Failed tests:

  • ❌ Safe Apps List Safe Apps List
  • ❌ Safe Balances Safe Balances

@usame-algan usame-algan marked this pull request as draft January 11, 2022 17:44
@iamacook iamacook marked this pull request as ready for review January 12, 2022 09:31
@iamacook iamacook marked this pull request as draft January 12, 2022 09:38
@iamacook iamacook marked this pull request as ready for review January 12, 2022 09:45
package.json Show resolved Hide resolved
@francovenica
Copy link
Contributor

I tried by connecting a user with MM that has a ENS name "francotest.eth" but I don't see the name. I'm trying this on Rinkeby
I tried in this PR use the ENS name in the address book to create an entry and the name still works.

ENS name: "francotest.eth"
Address: 0x61a0c717d18232711bC788F19C9Cd56a43cc8872
Rinkeby only

image

@usame-algan
Copy link
Member Author

I tried by connecting a user with MM that has a ENS name "francotest.eth" but I don't see the name.

The domain has to be set as the "Primary ENS Name" in the ENS App otherwise it won't be registered with the Resolver Contract
Screenshot 2022-01-18 at 11 47 13

@francovenica
Copy link
Contributor

Oh, didn't know about the primary ENS name.
I registered it and now it works

image

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@usame-algan usame-algan merged commit 6b83e9e into dev Jan 18, 2022
@usame-algan usame-algan deleted the safe-ens-domain-with-provider branch January 18, 2022 15:06
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants