Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Developer tools #3306

Merged
merged 10 commits into from
Jan 19, 2022
Merged

Developer tools #3306

merged 10 commits into from
Jan 19, 2022

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jan 14, 2022

Description

A basic implementation of Safe-related developer tools are now visible in the sidebar when not in the production envrionment.

These include links to:

  • Transaction queue
  • Transaction history
  • Safe status (courtest of Richard's personal tool)

Macros for:

  • Creating a queued transaction
  • Creeating and immediately executing a transaction (where possible)

These can, of course, be improved and expanded upon in the future.

Screenshots

Screenshot 2022-01-14 at 18 31 59

@iamacook iamacook self-assigned this Jan 14, 2022
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 14, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

coveralls commented Jan 14, 2022

@github-actions
Copy link

Deployment links

🟠 Safe Rinkeby Safe Mainnet 🟣 Safe Polygon 🟡 Safe BSC Safe Arbitrum 🟢 Safe xDai

@github-actions
Copy link

github-actions bot commented Jan 14, 2022

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1717432812

Failed tests:

  • ❌ Safe Apps List Safe Apps List
  • ❌ Read-only transaction creation and review Read-only transaction creation and review

@iamacook iamacook marked this pull request as ready for review January 14, 2022 17:32
@usame-algan usame-algan self-requested a review January 14, 2022 17:33
@katspaugh
Copy link
Member

katspaugh commented Jan 14, 2022

On my screen, it makes the sidebar quite cramped. I would place these tools in a new menubar on top (or bottom) of the app. Along with the CGW toggle.

Screenshot 2022-01-14 at 18 38 23

{!IS_PRODUCTION && safeAddress && (
<>
<StyledDivider />
<DevTools />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also lazy import it if possible, so that it's not imported on prod.

@iamacook
Copy link
Member Author

On my screen, it makes the sidebar quite cramped. I would place these tools in a new menubar on top (or bottom) of the app. Along with the CGW toggle

I think we'll quickly run out of space with extra features regardless of if we use the sidebar of an appbar. I feel like there's more wasted space in the sidebar (on my resolution at least).

I'd like to look into moving the devtools into a hideable popup, much like this.

@francovenica
Copy link
Contributor

The way it is looks fine, and is really helpful.
I like the idea of the hideable pop up, not for the cramp buttons, but because I still want to be able to see the page as users would do in prod (the full menu).

Also, If you allow me to be greedy, I'd love to have the endpoint in the "safe status" page that shows you the tx list, like this one:
https://safe-transaction.rinkeby.gnosis.io/api/v1/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/multisig-transactions/

@iamacook
Copy link
Member Author

Also, If you allow me to be greedy, I'd love to have the endpoint in the "safe status" page that shows you the tx list

I'm glad to hear you like it. The status page is not actually made by us but by Richard. Do you use the transaction endpoint often? We can simply add a link to it as part of the developer tools.

@francovenica
Copy link
Contributor

@iamacook
Copy link
Member Author

It is working fine for me @francovenica. Can someone else test this please? @gnosis/safe-web

@katspaugh
Copy link
Member

Works fine for me

@francovenica
Copy link
Contributor

Now I can barely see the menu on the sidebar ( I think the CGW switch was added right? ).
Also, I see the sidebar refreshing every 15/20 secs or so (you can see the sidebar flicker)

image

@iamacook
Copy link
Member Author

@francovenica, let's leave this for the time being. I'll come back to it on Friday seeing at there are more important tasks.

@katspaugh
Copy link
Member

@iamacook please feel free to merge it, as it will be immediately useful.

@iamacook
Copy link
Member Author

@iamacook please feel free to merge it, as it will be immediately useful.

It seems that there are a couple bugs. I enountered the issue @francovenica described. I'll look into this tomorrow morning and see if I can sort it.

@iamacook
Copy link
Member Author

I found the issue and pushed a fix. @francovenica, please confirm if you are having any further issues. Hopefully we can get this merged today.

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

@iamacook iamacook merged commit 6508ca1 into dev Jan 19, 2022
@francovenica
Copy link
Contributor

It works. Merge it

@iamacook iamacook deleted the dev-tool branch January 19, 2022 15:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants