-
Notifications
You must be signed in to change notification settings - Fork 360
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 1719849546
💛 - Coveralls |
E2E Tests Failed Failed tests:
|
@@ -56,7 +56,7 @@ export const processTransaction = (props: ProcessTransactionArgs): ProcessTransa | |||
safeAddress: props.safeAddress, | |||
to: tx.to, | |||
txData: tx.data ?? EMPTY_DATA, | |||
txNonce: '', | |||
txNonce: tx.nonce, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the refactoring fix that was merged into dev.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, so simple!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
So I was able to see it work with a safe 1 out of x owners. But I tried with other safes of 2 out of x but is not working because of the issue #3305 . |
I have just merged dev into this PR. Please lmk if it helps. |
Thanks for applying the fix. It works fine now |
What it solves
Resolves #3223
How this PR fixes it
When 'local' status updates occur, they are broadcast via a
BroadcastChannel
that then dispatches the payload once more with an extra flag to prevent endless broadcasts.Note: this is NOT supported by Safari.
How to test it
Screenshots