fix: transaction stage-relative execution

[iamacook]

What it solves

Resolves #3305

How this PR fixes it

Instead of blanket establishing isExecution within TxSender, the logic is now extracted into the respective transaction creation/processing function as the previous logic was before the refactor.

On top of this, the transaction proposal to backend now depends on whether the user is an owner.

How to test it

Every variation of transaction is affected by this. The cases are as follows:

1/? threshold:

1. Create and execute transaction immediately.
2. Queue transaction and execute later by owner.
3. Queue transaction and execute by non-owner.

2+/? threshold:

1. Create and confirm transaction then execute by owner(s).
2. Create and confirm transaction then execute by non-owner.

Safe creation

1. Create Safe successfully.

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[coveralls]

Pull Request Test Coverage Report for Build 1714003035

• 0 of 5 (0.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.01%) to 32.441%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/logic/safe/store/actions/processTransaction.ts	0	2	0.0%
src/logic/safe/store/actions/createTransaction.ts	0	3	0.0%

Totals
Change from base Build 1713602320:	-0.01%
Covered Lines:	3163
Relevant Lines:	8701

---

💛 - Coveralls

[github-actions]

Deployment links

🟠 Rinkeby	⚪ Mainnet	🟣 Polygon	🟡 BSC	⚫ Arbitrum	🟢 Gnosis Chain

[github-actions]

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1714045584

Failed tests:

• ❌ Safe Apps List Safe Apps List

[francovenica]

Looks good to me.

Also checked tx rejections and tried with my trezor and ledger as well

[iamacook]

I'm merging this to fix the error on dev as it has been tested and is working. However, we are still proposing when we shouldn't be. This doesn't cause issues (and was this way for months) but we should still try to fix it when we get the chance. I've created an issue for that here.