Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

fix: throttle queue transaction macro #3384

Merged
merged 4 commits into from
Jan 31, 2022
Merged

fix: throttle queue transaction macro #3384

merged 4 commits into from
Jan 31, 2022

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jan 28, 2022

What it solves

Preventing queue macro spam.

How this PR fixes it

The queue transaction macro function is now throttled. Clicking it invokes the macro but subsequent clicks don't.

How to test it

  • Click the queue transaction dev tool button and observe that it does not allow the creation of a transaction repeatedly.

@iamacook iamacook self-assigned this Jan 28, 2022
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 28, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

coveralls commented Jan 28, 2022

Pull Request Test Coverage Report for Build 1770000567

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 33.629%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/AppLayout/Sidebar/DevTools/index.tsx 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/AppLayout/Sidebar/DevTools/index.tsx 1 0%
Totals Coverage Status
Change from base Build 1760720190: -0.003%
Covered Lines: 3187
Relevant Lines: 8485

💛 - Coveralls

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

Copy link
Member

@DiogoSoaress DiogoSoaress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! 🚀

Copy link
Member

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@francovenica
Copy link
Contributor

As soon as I enter into any safe a modal tries to open constantly and locks my tab.
01-28-2022_x(4065)

@francovenica
Copy link
Contributor

Even after the last commit I still get the modal popping up as soon as I open the build (the build already has a safe by default).
Looks the same as the gif I posted above

@iamacook
Copy link
Member Author

@francovenica, I've changed the debouncing and it should now work as intended

@iamacook iamacook changed the title fix: debouce queue transaction macro fix: throttle queue transaction macro Jan 30, 2022
@github-actions
Copy link

E2E Tests Failed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1770020785

Failed tests:

  • ❌ Read-only transaction creation and review Read-only transaction creation and review

@DiogoSoaress
Copy link
Member

@iamacook 👍 to move it to QA

@francovenica
Copy link
Contributor

Looks good! the popUp is not jumping anymore as soon as I get in the safe.

@iamacook iamacook merged commit 0a2dc17 into dev Jan 31, 2022
@iamacook iamacook deleted the debounce-queue-macro branch January 31, 2022 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants