-
Notifications
You must be signed in to change notification settings - Fork 360
fix: throttle queue transaction macro #3384
Conversation
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Pull Request Test Coverage Report for Build 1770000567
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Even after the last commit I still get the modal popping up as soon as I open the build (the build already has a safe by default). |
@francovenica, I've changed the debouncing and it should now work as intended |
E2E Tests Failed Failed tests:
|
@iamacook 👍 to move it to QA |
Looks good! the popUp is not jumping anymore as soon as I get in the safe. |
What it solves
Preventing queue macro spam.
How this PR fixes it
The queue transaction macro function is now throttled. Clicking it invokes the macro but subsequent clicks don't.
How to test it